Add goverment shutdown notice #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we still need to merge it or was the situation resolved? |
|
You could change it to more of an "if" clause, like "in the case of..." and then you don't have to jump back and forth @chrisfilo as long as the oompa loompa is around, I think we will continue to have a "situation..." 🍊 |
|
Situation is resolved, unfortunately, the language for the notice is not something we can change without approval. We could add an environment variable and rebuild when there’s a shutdown. Should I submit a PR with that added?
…Sent from my iPhone
On Jan 22, 2018, at 9:15 PM, Vanessa Sochat ***@***.***> wrote:
You could change it to more of an "if" clause, like "in the case of..." and then you don't have to jump back and forth @chrisfilo as long as the oompa loompa is around, I think we will continue to have a "situation..." 🍊
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Sounds like a plan. This could be implemented in the current PR. Thanks!
Best,
Chris
On Tue, Jan 23, 2018 at 4:32 AM, Dylan Nielson <notifications@github.com>
wrote:
… Situation is resolved, unfortunately, the language for the notice is not
something we can change without approval. We could add an environment
variable and rebuild when there’s a shutdown. Should I submit a PR with
that added?
Sent from my iPhone
> On Jan 22, 2018, at 9:15 PM, Vanessa Sochat ***@***.***>
wrote:
>
> You could change it to more of an "if" clause, like "in the case of..."
and then you don't have to jump back and forth @chrisfilo as long as the
oompa loompa is around, I think we will continue to have a "situation..." 🍊
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOkp9sS9RF3xzr2ZRJHa_vwfPF8bwGgks5tNdFzgaJpZM4RoO7->
.
|
|
Even better would be to drop in some javascript to pull the operating
status from the Office of Personnel Management's JSON API
<https://www.opm.gov/developer/documentation/current-status-api/> and look
for the phrase "lapse in appropriations". In the last two shutdowns, that
phrase was used in the StatusSummary field. I'll try to get that
implemented this week.
On Tue, Jan 23, 2018 at 11:03 AM, Chris Filo Gorgolewski <
notifications@github.com> wrote:
… Sounds like a plan. This could be implemented in the current PR. Thanks!
Best,
Chris
On Tue, Jan 23, 2018 at 4:32 AM, Dylan Nielson ***@***.***>
wrote:
> Situation is resolved, unfortunately, the language for the notice is not
> something we can change without approval. We could add an environment
> variable and rebuild when there’s a shutdown. Should I submit a PR with
> that added?
>
> Sent from my iPhone
>
> > On Jan 22, 2018, at 9:15 PM, Vanessa Sochat ***@***.***>
> wrote:
> >
> > You could change it to more of an "if" clause, like "in the case of..."
> and then you don't have to jump back and forth @chrisfilo as long as the
> oompa loompa is around, I think we will continue to have a
"situation..." 🍊
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub, or mute the thread.
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/poldracklab/mriqcwebapi/pull/
38#issuecomment-359776655>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-
auth/AAOkp9sS9RF3xzr2ZRJHa_vwfPF8bwGgks5tNdFzgaJpZM4RoO7->
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFC1mGoR3l_XPSZjCcT1S3Q_5nadesJlks5tNgLfgaJpZM4RoO7->
.
|
|
Me might be overengineering a solution for an event that happens once in 4
years :)
Best,
Chris
On Tue, Jan 23, 2018 at 11:49 AM, Dylan Nielson <notifications@github.com>
wrote:
… Even better would be to drop in some javascript to pull the operating
status from the Office of Personnel Management's JSON API
<https://www.opm.gov/developer/documentation/current-status-api/> and look
for the phrase "lapse in appropriations". In the last two shutdowns, that
phrase was used in the StatusSummary field. I'll try to get that
implemented this week.
On Tue, Jan 23, 2018 at 11:03 AM, Chris Filo Gorgolewski <
***@***.***> wrote:
> Sounds like a plan. This could be implemented in the current PR. Thanks!
>
> Best,
> Chris
>
> On Tue, Jan 23, 2018 at 4:32 AM, Dylan Nielson ***@***.***
>
> wrote:
>
> > Situation is resolved, unfortunately, the language for the notice is
not
> > something we can change without approval. We could add an environment
> > variable and rebuild when there’s a shutdown. Should I submit a PR with
> > that added?
> >
> > Sent from my iPhone
> >
> > > On Jan 22, 2018, at 9:15 PM, Vanessa Sochat <
***@***.***>
> > wrote:
> > >
> > > You could change it to more of an "if" clause, like "in the case
of..."
> > and then you don't have to jump back and forth @chrisfilo as long as
the
> > oompa loompa is around, I think we will continue to have a
> "situation..." 🍊
> > >
> > > —
> > > You are receiving this because you authored the thread.
> > > Reply to this email directly, view it on GitHub, or mute the thread.
> > >
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <https://github.com/poldracklab/mriqcwebapi/pull/
> 38#issuecomment-359776655>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-
> auth/AAOkp9sS9RF3xzr2ZRJHa_vwfPF8bwGgks5tNdFzgaJpZM4RoO7->
> > .
>
> >
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/poldracklab/mriqcwebapi/pull/
38#issuecomment-359838522>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-
auth/AFC1mGoR3l_XPSZjCcT1S3Q_5nadesJlks5tNgLfgaJpZM4RoO7->
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOkp1LIWUPr2m-GHw3atO9BysqQ_dnnks5tNjfHgaJpZM4RoO7->
.
|
|
Might happen again in 3 weeks though.
…Sent from my iPhone
On Jan 23, 2018, at 4:43 PM, Chris Filo Gorgolewski ***@***.***> wrote:
Me might be overengineering a solution for an event that happens once in 4
years :)
Best,
Chris
On Tue, Jan 23, 2018 at 11:49 AM, Dylan Nielson ***@***.***>
wrote:
> Even better would be to drop in some javascript to pull the operating
> status from the Office of Personnel Management's JSON API
> <https://www.opm.gov/developer/documentation/current-status-api/> and look
> for the phrase "lapse in appropriations". In the last two shutdowns, that
> phrase was used in the StatusSummary field. I'll try to get that
> implemented this week.
>
> On Tue, Jan 23, 2018 at 11:03 AM, Chris Filo Gorgolewski <
> ***@***.***> wrote:
>
> > Sounds like a plan. This could be implemented in the current PR. Thanks!
> >
> > Best,
> > Chris
> >
> > On Tue, Jan 23, 2018 at 4:32 AM, Dylan Nielson ***@***.***
> >
> > wrote:
> >
> > > Situation is resolved, unfortunately, the language for the notice is
> not
> > > something we can change without approval. We could add an environment
> > > variable and rebuild when there’s a shutdown. Should I submit a PR with
> > > that added?
> > >
> > > Sent from my iPhone
> > >
> > > > On Jan 22, 2018, at 9:15 PM, Vanessa Sochat <
> ***@***.***>
> > > wrote:
> > > >
> > > > You could change it to more of an "if" clause, like "in the case
> of..."
> > > and then you don't have to jump back and forth @chrisfilo as long as
> the
> > > oompa loompa is around, I think we will continue to have a
> > "situation..." 🍊
> > > >
> > > > —
> > > > You are receiving this because you authored the thread.
> > > > Reply to this email directly, view it on GitHub, or mute the thread.
> > > >
> > >
> > > —
> > > You are receiving this because you were mentioned.
> > > Reply to this email directly, view it on GitHub
> > > <https://github.com/poldracklab/mriqcwebapi/pull/
> > 38#issuecomment-359776655>,
> > > or mute the thread
> > > <https://github.com/notifications/unsubscribe-
> > auth/AAOkp9sS9RF3xzr2ZRJHa_vwfPF8bwGgks5tNdFzgaJpZM4RoO7->
> > > .
> >
> > >
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <https://github.com/poldracklab/mriqcwebapi/pull/
> 38#issuecomment-359838522>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-
> auth/AFC1mGoR3l_XPSZjCcT1S3Q_5nadesJlks5tNgLfgaJpZM4RoO7->
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#38 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAOkp1LIWUPr2m-GHw3atO9BysqQ_dnnks5tNjfHgaJpZM4RoO7->
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I guess we will finally need to get this merged, DYT? EDIT: luckily it took some 50 weeks |
|
Nah, we're funded, it's only a partial shutdown. :)
…On Wed, Jan 2, 2019 at 7:48 PM Oscar Esteban ***@***.***> wrote:
I guess we will finally need to get this merged, DYT?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFC1mKB6ExxmDTm0wN6wfgbKjBedBZylks5u_VNLgaJpZM4RoO7->
.
|
|
Only partial? Hmm. Ctrl+Z?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got to add language about the shutdown to all external facing government websites. There isn't actually any change in the functional status of the webpage, but we've got to have the language there. Please merge this in when you get a chance.